Skip to content

feat: track datafog-core 1.4.0 email-boundary defaults - #186

Merged
sidmohan0 merged 1 commit into
mainfrom
train/4.11-email-boundaries
Nov 15, 2026
Merged

sidmohan0 merged 1 commit into
mainfrom
train/4.11-email-boundaries

Conversation

@sidmohan0

Copy link
Copy Markdown
Contributor

What changes

datafog-core 1.4.0 (datafog-core#249, #250) trims label syntax in default text-mode email spans, so email=alice@example.com reports alice@example.com, quoted values drop the wrapping quote, and SUPPORT_EMAIL= labels stay out of the span. This PR puts the facade on that train:

  • Dependency floor raised to datafog-core>=1.4.0,<2 (both the default extra and [rust]).
  • Reviewed Rust contract file renamed to tests/contracts/rust-1.4.0.json with core_version 1.4.0. No new deviations: I ran tests/rust_contract.py's observation harness against a real 1.4.0 wheel; all 76 in-scope cases still match their recorded expectations (3 detector-difference, 1 validation-difference, unchanged).
  • Native corpus: json-escaped and markdown-code-block divergences resolve and are removed. unicode-chinese-name stays with a corrected reason — its corpus fixture contains literal ? characters, which are valid RFC local-part characters, so the reviewed expectation remains overlap-only.
  • Version 4.11.0 (MINOR: finding spans change) and a CHANGELOG entry.

Verification

  • pytest tests/test_rust_contract.py tests/test_detection_accuracy.py tests/test_contract_481.py with DATAFOG_ACCURACY_BACKEND=rust and datafog-core 1.4.0 installed: 447 passed.
  • Full suite in one environment: unmodified main fails 11 tests (async teardown + optional-dependency gaps); this branch fails 10 — one accuracy case improves, no regressions.
  • JSON files prettier-formatted.

Core 1.4.0's text-mode email scanning trims label syntax by default, so
`email=alice@example.com` reports `alice@example.com` and quoted values drop
the wrapping quote. This moves the reviewed Rust contract file to
`rust-1.4.0.json` (no new deviations: every recorded case still matches,
verified by running the observation harness against 1.4.0), raises the
dependency floor, and resolves the `json-escaped` and `markdown-code-block`
native-corpus divergences.

`unicode-chinese-name` stays with a corrected reason: its corpus fixture
contains literal `?` characters, which are valid local-part characters, so the
reviewed expectation remains overlap-only.

Also stops the local verification gap this exposed: the two async/optional
dependency failures and one accuracy improvement are relative to an unmodified
main in the same environment (11 failed there, 10 here).
@sidmohan0
sidmohan0 merged commit 4f9b126 into main Nov 15, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant